[libvirt] [PATCH 1/5] qemuDomainDetachChrDevice: Use @tmpChr to build device string
So far we are passing @chr to qemuBuildChrDeviceStr. This is
suboptimal beacuse @chr is just parsed XML definition provided by
user which by definition may lack some information. On the other
hand, @tmpChr is the one that was found using @chr in domain
definition so it contains the same amount of information or more.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 38600b33f8..01920a78f5 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -6131,7 +6131,7 @@ int qemuDomainDetachChrDevice(virQEMUDriverPtr driver,
sa_assert(tmpChr->info.alias);
- if (qemuBuildChrDeviceStr(&devstr, vmdef, chr, priv->qemuCaps) < 0)
+ if (qemuBuildChrDeviceStr(&devstr, vmdef, tmpChr, priv->qemuCaps) < 0)
goto cleanup;
if (!async)
--
2.19.2