[Libvir] [PATCH] add error message for the case of "vcpupin" fails
Hi,
When I set a number that is bigger than
virtual CPU's setting of guest_dom to <vcpu>,
No error-messages are shown.
I try follow,
# virsh vcpupin guest_dom 100 0,1
[no error messages]
# echo $?
1
I make the patch to solve this problem.
Thanks,
Shigeki Sakamoto.
Index: virsh.c
===================================================================
RCS file: /data/cvs/libvirt/src/virsh.c,v
retrieving revision 1.140
diff -u -p -r1.140 virsh.c
--- virsh.c 27 Mar 2008 13:43:01 -0000 1.140
+++ virsh.c 4 Apr 2008 05:21:47 -0000
@@ -1747,6 +1747,7 @@ cmdVcpupin(vshControl * ctl, vshCmd * cm
}
if (vcpu >= info.nrVirtCpu) {
+ vshError(ctl, FALSE, _("vcpupin: Invalid vCPU number."));
virDomainFree(dom);
return FALSE;
}