On 6/20/19 2:39 PM, Michal Privoznik wrote:
> On 6/17/19 3:34 PM, Daniel P. Berrangé wrote:
>> On Mon, Jun 03, 2019 at 06:07:02PM +0200, Michal Privoznik wrote:
>>> On 4/25/19 10:19 AM, Michal Privoznik wrote:
>>>>
>>>> This is meant for next release to have the most time possible for
>>>> testing. Some of the patches were ACKed in v3 already but since they
>>>> don't make sense on their own I haven't pushed them.
>>>>
>>>> v4 of:
>>>>
>>>>
https://www.redhat.com/archives/libvir-list/2019-March/msg01948.html
>>>>
>>>> As usual, you can find (not only these) patches on my github:
>>>>
>>>>
https://github.com/zippy2/libvirt branch xattr_fixes_v4
>>>
>>> Ping?
>>
>> Looks good - just have 1 question against patch 18 before I can ack
>> that patch.
>>
>>
>
> Thank you both Dan and Cole for the review! However, given how close to
> the freeze we are and how intrusive this change is, I'd rather keep
> these in a local branch and merge only after the release to give us the
> longest window possible for test.
This is now pushed. I'll work on the follow up patches soon.
Looks like we hit a unit test failure on the FreeBSD CI systems.
Regards,
Daniel
--
|: