Re: [libvirt] [PATCH 21/24] hostdev: Stop early if unmanaged devices have not been detached

> As for your question, a device might end up in the inactive > list because of: >  >   * PreparePCIDevices(), step 2, if managed. Just temporarily, >     it's moved to the active list in step 5 >  >   * ReattachPCIDevices(), step 4, whether managed or >     unmanaged. If it's managed is also removed from the >     inactive list in the same step, if it's unmanaged it >     will remain in the inactive list >  >   * PCINodeDeviceDetach() >  > This is not including rollback paths. So it ends up in the > inactive list when it's either *not yet* active, or *no > longer* active. >  > > I don't disagree this is an important step, but it's the "how" we > > determine this that I'm questioning. >  > Hopefully the above helped :)   Partially, let's consider an initial startup where Prepare is called (and I assume we don't call either virHostdevReattachPCIDevice or virHostdevPCINodeDeviceDetach yet).   So how does this code check if the device has been manually detached from the host? Step 1 doesn't add to the inactiveList and step 2 only adds managed devices.  How would that lookaside element be on the inactiveList - what put it there?   Is there some magic w/ virHostdevPCINodeDeviceDetach that I'm missing?