On Tue, Feb 15, 2011 at 6:42 PM, Daniel P. Berrange <berrange@redhat.com> wrote:
On Tue, Feb 15, 2011 at 03:03:52PM +0800, Lyre wrote:
> * libvirt-php.obs.spec: this file should works for Fedora 14,
>   openSuSE 11.3, and SLES 11 SP1 on openSuSE Build Service or
>   localhost.
> * Makefile.am: added EXTRA_DIST = libvirt-php.obs.spec
> ---
>  Makefile.am          |    2 +
>  aclocal.m4           |    4 +-
>  libvirt-php.obs.spec |   80 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 84 insertions(+), 2 deletions(-)
>  create mode 100644 libvirt-php.obs.spec

Why do we need another RPM specfile ? Can't you just make your
changes to the existing php-libvirt.spec ?

Regards,
Daniel
--
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Hi Daniel:

The problem was, I'm not quite sure what to do with this spec file.

Currently, It may be better to name the spec file libvirt-php.spec.

This spec file contains many if...else for compatibility, some macros such as %{php_zend_api} are not acceptable in SLES. The original php-libvirt.spec may be preferred for Fedora.

At last, I intend to use the openSuSE Build Service for easier deployment. It will be easier for me to maintain this file if it is rejected.