Re: [PATCH RESEND v1] xen: recognize device_model_override
On 12/7/20 10:15 AM, Olaf Hering wrote:
Am Thu, 19 Nov 2020 16:11:34 -0700
schrieb Jim Fehlig <jfehlig(a)suse.com>:
> On 11/19/20 12:58 PM, Olaf Hering wrote:
>> Am Mon, 16 Nov 2020 19:48:28 -0700
>> schrieb Jim Fehlig <jfehlig(a)suse.com>:
>>> Correct. It is selected based on the specified <emulator> and not
modeled in
>>> domXML. Does it need to be exposed to the user? AFAIK those are the only two
>>> values we care about, and it is possible to determine which to use based on
the
>>> <emulator>.
>> I think 'device_model_version' can be ignored.
> I think we need to take a closer look. It is not explicitly set in
> libxl_domain_build_info_init(), hence would be set to
> LIBXL_DEVICE_MODEL_VERSION_UNKNOWN.
libxl__domain_build_info_setdefault sets it, if needed.
libxl_domain_create_new
do_domain_create
initiate_domain_create
libxl__domain_config_setdefault
libxl__domain_build_info_setdefault
Which, if needed, calls libxl__default_device_model in the various
libxl_<os-flavor>.c files.
Otherwise 'xl create' would fail as well if
device_model_version= is missing domU.cfg.
Yes, good point!
Jim