On Tue, Mar 24, 2020 at 06:23:19PM +0000, Daniel P. Berrangé wrote:
On Tue, Mar 24, 2020 at 06:51:10PM +0100, Andrea Bolognani wrote:
On Tue, 2020-03-24 at 16:24 +0000, Daniel P. Berrangé wrote:
+# This artifact published by this job is downloaded to push to Weblate +# for translation usage: +# https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=potf... +potfile: + stage: prebuild + only: + refs: + - master
As discussed in patch 6/9, it would make more sense for this to be in a postbuild stage, after all other builds have succeeded, than in a prebuild stage.
We want the pot file build to run regardless of whether the other builds succeed. There may be transient failures with builds and we want to publish the pot & website content regardless, once it is in master.
That explanation makes sense. Reviewed-by: Erik Skultety <eskultet@redhat.com>