Re: [libvirt] [PATCH 5/8] Enable the virDomainBlockPull API in virsh
On 06/14/2011 04:59 AM, Daniel P. Berrange wrote:
> +static bool
> +cmdBlockPullAll(vshControl *ctl, const vshCmd *cmd)
> +{
> + int mode;
> +
> + if (vshCommandOptBool (cmd, "abort"))
> + mode = VSH_CMD_BLOCK_PULL_ABORT;
> + else
> + mode = VSH_CMD_BLOCK_PULL_ALL;
> +
> + if (blockPullImpl(ctl, cmd, NULL, mode) != 0)
> + return false;
> + return true;
> +}
In constrast to the API, I think it might be worth merging this command
with "blockpull", just having a '--all' flag for it.
This was an easy change to make. You'll see it in the next posting.
I've added the flags '--all' and '--abort' to the blockpull command.
Now we have just two virsh commands: blockpull and blockpullinfo.
--
Adam Litke
IBM Linux Technology Center