Re: [libvirt] [PATCH v3 3/6] admin: Move admin_server.{h, c} to admin.{h, c}
On Mon, Nov 30, 2015 at 04:03:02PM +0100, Erik Skultety wrote:
This change is merely because admin_server would contain all the code
from dispatchers and helpers to the actual APIs. Admin should have
similar structure to the daemon-side remote driver - dispatchers and
helpers in a separate module, APIs in a separate module.
Best viewed with -M.
And if you saw it with -M you would see this is just a rename. Apart
from two things:
diff --git a/daemon/Makefile.am b/daemon/Makefile.am
index be1b5a9..5b13960 100644
--- a/daemon/Makefile.am
+++ b/daemon/Makefile.am
@@ -42,6 +42,7 @@ DAEMON_SOURCES = \
libvirtd.c libvirtd.h \
remote.c remote.h \
stream.c stream.h \
+ admin.c admin.h \
a) You are compiling the admin.[ch] inside the daemon for some reason,
even though it's in libvirtd_admin_la that is added there as well.
@@ -319,7 +320,8 @@ endif ! WITH_POLKIT
remote.c: $(DAEMON_GENERATED)
remote.h: $(DAEMON_GENERATED)
-admin_server.c: $(DAEMON_GENERATED)
+admin.c: $(DAEMON_GENERATED)
+admin.h: $(DAEMON_GENERATED)
This was missing, not really needed, but nicer to have it mentioned.
diff --git a/daemon/admin_server.h b/daemon/admin_server.h
deleted file mode 100644
index 26721a6..0000000
--- a/daemon/admin_server.h
+++ /dev/null
@@ -1,36 +0,0 @@
-/*
- * admin_server.h
- *
- * Copyright (C) 2014 Red Hat, Inc.
- *
b) You changed this 2014 copyright ...
diff --git a/daemon/admin.h b/daemon/admin.h
new file mode 100644
index 0000000..1e6802a
--- /dev/null
+++ b/daemon/admin.h
@@ -0,0 +1,36 @@
+/*
+ * admin.h: handlers for admin RPC method calls
+ *
+ * Copyright (C) 2015 Red Hat, Inc.
+ *
... to 2015 here.
ACK with those two things fixed.
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)