On 9/25/25 20:06, Andrea Bolognani via Devel wrote:
Changes from [v1]:
* overhaul/fix validation of USB controllers. Previously the check was based around whether the controller had a PCI address assigned to it, but that was incorrect and insufficient. The new check is based on the controller model instead;
* split functional changes in the last stretch of the series into smaller chunks and justify each one separately;
* avoid use of nec-xhci for RISC-V and LoongArch;
* add test suite coverage and special handling for microvm;
* address other review comments.
[v1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/D7VFK...
Andrea Bolognani (38): tests: Fix typo in usb-controller-nec-xhci-autoassign tests: Drop coverage for versatilepb on aarch64 tests: Don't use memballoon=none for minimal tests tests: Don't set PCI address in usb-controller-default tests tests: Minimize usb-controller tests tests: Rename usb-controller-implicit-* tests: Expand coverage for automatic/default USB controllers tests: Fix some usb-controller-*-unavailable cases qemu: Check for pci-ohci availability tests: Use realview-eb instead of realview-pbx-a9 qemu: Fix PCI/USB handling for Arm realview boards tests: Add coverage for PCI use with isapc and microvm qemu: Don't add memballoon to isapc qemu: Don't add PCI, USB or memballoon to microvm qemu: Introduce qemuDomainNetIsPCI() qemu: Prevent use of PCI devices when PCI is not supported qemu: Validate presence of PCI support qemu: Update qemuDomainSupportsPCI() qemu: Add sanity checks for auto-added PCI and USB controllers qemu: Always default to no USB controller on s390x qemu: Don't generate alias for model=none USB controllers qemu: Drop skip for USB controllers on s390x qemu: Fold check into qemuBuildSkipController() qemu: Rename function argument qemu: Validate PCI support for USB controllers qemu: Skip USB controller validation when model=none qemu: Validate USB controllers earlier qemu: Add qemuDomainDefaultUSBControllerModel() qemu: Add qemuDomainDefaultUSBControllerModelAutoAdded() qemu: Clean up qemuDomainDefaultUSBControllerModel() qemu: Clean up qemuDomainDefaultUSBControllerModelAutoAdded() qemu: Use qemu-xhci with no fallback on loongarch64 qemu: Use qemu-xhci with no fallback on RISC-V qemu: Unify USB controllers across Arm architectures qemu: Don't special-case realview/versatilebp for USB qemu: Remove fallback to piix3-uhci for Arm virt guests qemu: Remove use of piix3-uhci for non-x86 news: Update for USB controller model selection improvements
212 files changed, 930 insertions(+), 1579 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal