On 01/13/2015 09:41 AM, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1181408
when we try to hotplug a channel chr device with no target, we will get success(which should fail) in virDomainChrDefParseXML, because we use goto cleanup this place and return def.then cause a big problem in virDomainChrEquals(touch a shouldn't happend place).
The problem is that ChrEquals matches according to the target name, so after we add the device to the domain definition, we cannot remove it after failure, leaving a stale pointer there.
Signed-off-by: Luyao Huang <lhuang@redhat.com> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK I have added the explanation to the commit message and pushed the patch. Jan