On 12/31/2011 12:01 PM, Eric Blake wrote:
On 12/29/2011 12:33 AM, Hu Tao wrote:
The APIs are used to set/get domain's network interface's parameters. Currently supported parameters are bandwidth settings.
+++ b/include/libvirt/libvirt.h.in @@ -645,6 +645,48 @@ typedef virTypedParameter *virTypedParameterPtr; */ #define VIR_DOMAIN_SCHEDULER_SHARES "shares"
+/** + * VIR_DOMAIN_BANDWIDTH_IN_AVERAGE: + * + * Macro represents the inbound average of NIC bandwidth. + */ +#define VIR_DOMAIN_BANDWIDTH_IN_AVERAGE "inbound.average"
We should modify these comments to state what the expected associated type will be when using this named parameter, as well as which scheduler it will be used with (see VIR_DOMAIN_SCHEDULER_CPU_SHARES for an example).
Actually, I think these macro definitions should be moved down closer to the declaration of virDomainGetInterfaceParameters, as they have nothing to do with virDomainGetSchedulerParameters. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org