Re: [libvirt] [PATCH v3 19/26] tests: Add tests for pSeries guests with multiple PHBs

On Fri, 2017-06-23 at 23:03 +0800, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani <abologna(a)redhat.com&gt; > --- > .../qemuxml2argv-pseries-phb-default-missing.args | 22 +++++++++++++++ > .../qemuxml2argv-pseries-phb-default-missing.xml | 16 +++++++++++ > .../qemuxml2argv-pseries-phb-simple.args | 22 +++++++++++++++ > .../qemuxml2argv-pseries-phb-simple.xml | 17 +++++++++++ > tests/qemuxml2argvtest.c | 8 ++++++ > .../qemuxml2xmlout-pseries-phb-default-missing.xml | 33 ++++++++++++++++++++++ > .../qemuxml2xmlout-pseries-phb-simple.xml | 33 ++++++++++++++++++++++ > tests/qemuxml2xmltest.c | 7 +++++ > 8 files changed, 158 insertions(+) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-phb-default-missing.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-phb-default-missing.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-phb-simple.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-phb-simple.xml > create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-phb-default-missing.xml > create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-phb-simple.xml The attached patch should be squashed in to make sure the new test implemented in [1] works correctly. In order for the test case to work, [2] will need to be merged first - I plan to squeeze it in between patches 07 and 08 before pushing. Does that sound reasonable?