Re: [libvirt] [PATCH v3 1/3] Add virXMLValidateAgainstSchema helper method

On Fri, Jan 16, 2015 at 01:58:27PM +0000, Ian Campbell wrote: > Hello, > > On Tue, 2015-01-13 at 17:00 +0000, Daniel P. Berrange wrote: > > +# define VIR_WARNINGS_NO_PRINTF \ > > + _Pragma ("GCC diagnostic push") \ > > + _Pragma ("GCC diagnostic ignored \"-Wsuggest-attribute=format\"") > > Xen automated tests are failing to build on all architectures with: > > util/virxml.c: In function 'catchRNGError': > util/virxml.c:1094:9: error: unknown option after '#pragma GCC diagnostic' kind [-Werror=pragmas] > > which I think must be down to one of these additions. > > (helpful of gcc not to print the unknown option in question!) > > test overview: > http://www.chiark.greenend.org.uk/~xensrcts/logs/33443/ > specific failure log: > http://www.chiark.greenend.org.uk/~xensrcts/logs/33443/build-amd64-libvir... > > We use Debian Wheezy's gcc, which is 4.6.3 AFAIK. The configure logs show checking whether C compiler handles -Wsuggest-attribute=const... yes checking whether C compiler handles -Wsuggest-attribute=format... no checking whether C compiler handles -Wsuggest-attribute=noreturn... yes checking whether C compiler handles -Wsuggest-attribute=pure... yes So, can someone with a Debian machine check if it helps to modify _Pragma ("GCC diagnostic ignored \"-Wsuggest-attribute=format\"") To be just _Pragma ("GCC diagnostic ignored \"-Wsuggest-attribute\"")