On Fri, Apr 07, 2017 at 07:58:11 -0400, John Ferlan wrote:
On 04/07/2017 07:54 AM, Peter Krempa wrote:
On Fri, Apr 07, 2017 at 07:49:57 -0400, John Ferlan wrote:
Create a wrapper/helper that can be used to call the storage backend wipe helper - storageBackendVolWipeLocalFile for future use by logical and disk backends to clear out the partition table rather than having each open code the same algorithm.
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/storage/storage_util.c | 18 ++++++++++++++++++ src/storage/storage_util.h | 4 ++++ 2 files changed, 22 insertions(+)
diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 8e25984..784df7a 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -4087,3 +4087,21 @@ virStorageBackendSCSIFindLUs(virStoragePoolObjPtr pool,
return found; } + + +/* + * @path: Path to the device to initialize + * @size: Size to be cleared + * + * Clear out device header for the purpose of being able to write + * some sort of partition to the device. + * + * Returns 0 on success, -1 on failure with error message set + */ +int +virStorageBackendZeroDeviceHeader(const char *path, + unsigned long long size) +{ + return storageBackendVolWipeLocalFile(path, VIR_STORAGE_VOL_WIPE_ALG_ZERO, + size);
Do you plan on adding stuff here? otherwise it's quite useless.
You mean like merging patch 1 and 2? I started that way, but waffled back and forth finally deciding upon the one thing at a time approach.
No. I meant using storageBackendVolWipeLocalFile directly. In fact this is kind of useful since storageBackendVolWipeLocalFile is not exported, so this patch hacks-around that fact, by exporting this new helper. That makes kind of sense. ACK