Re: [libvirt] [PATCH] qemudDomainSetVcpus: avoid NULL-deref on failed uuid look-up
Eric Blake wrote:
On 05/17/2010 11:33 AM, Jim Meyering wrote:
> Here's the fix, followed by the endjob/cleanup code:
>
>>From d696f6067d6e802714adbf3e36bf53c9fcf3ec76 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering(a)redhat.com>
> Date: Mon, 17 May 2010 19:28:44 +0200
> Subject: [PATCH] qemudDomainSetVcpus: avoid NULL-deref on failed uuid look-up
>
> * src/qemu/qemu_driver.c (qemudDomainSetVcpus): Upon look-up failure,
> i.e., vm==NULL, goto cleanup, rather than to "endjob", superficially
> since the latter would dereference vm, but more fundamentally because
> we certainly don't want to call qemuDomainObjEndJob before we've
> even attempted qemuDomainObjBeginJob.
ACK.
Thanks. Pushed.