Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system
On Fri, Sep 20, 2019 at 2:34 PM Fabiano Fidêncio <fidencio(a)redhat.com> wrote:
[snip]
>
> > In general, it looks good and works as expected.
> > I will add my "Reviewed-by: " after we discuss the points raised.
> >
> > Another thing, please, let's sync to have the libvirt-jenkins-ci work
> > done and merged before this one gets merged.
>
> Works for me, thanks for review, I'll fix the dist script to use a shell
> script.
>
Reviewed-by: Fabiano Fidêncio <fidencio(a)redhat.com>
One last things here (thanks, Pavel, for pointing this out), I'd
prefer the 'syntax' suite being called 'syntax-check' just because
people are already used to the 'syntax-check' name.
So, please, would you mind changing it as well?
Best Regards,
--
Fabiano Fidêncio