On Mon, Jan 06, 2020 at 05:26:49PM +0000, Daniel P. Berrangé wrote:
g_fsync was introduced in 2.63 which is newer than our minimum
glib version. A future commit will introduce compile time
checking of API versions to prevent accidental usage of APIs
from glib newer than our min declared.
To avoid triggering this warning, however, we need to ensure
that we always use our wrapper function via glibcompat.c,
which will disable the API version warnings.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
src/util/glibcompat.c | 1 +
src/util/glibcompat.h | 5 ++---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/util/glibcompat.c b/src/util/glibcompat.c
index 4ebefb4478..9fba54cb79 100644
--- a/src/util/glibcompat.c
+++ b/src/util/glibcompat.c
@@ -55,6 +55,7 @@ vir_g_strdup_vprintf(const char *msg, va_list args)
}
+/* Drop when min glib >= 2.63.0 */
These "drop when something >= version" are usually overlooked and stick
around longer then necessary, should we add a check that would produce
compile time warning if we bump the minimal version of glib?
Pavel