Re: [libvirt] [dbus PATCH 04/15] Implement Active property for Interface Interface
On Fri, Jul 06, 2018 at 05:36:44PM -0400, Anya Harter wrote:
Signed-off-by: Anya Harter <aharter(a)redhat.com>
---
data/org.libvirt.Interface.xml | 4 ++++
src/interface.c | 22 ++++++++++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index e6d9f2a..f50bc37 100644
--- a/data/org.libvirt.Interface.xml
+++ b/data/org.libvirt.Interface.xml
@@ -13,5 +13,9 @@
value="See
https://libvirt.org/html/libvirt-libvirt-interface.html#virInterfaceGetMA...
<annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal"
value="const"/>
</property>
+ <property name="Active" type="b" access="read">
+ <annotation name="org.gtk.GDBus.DocString"
+ value="See
https://libvirt.org/html/libvirt-libvirt-interface.html#virInterfaceIsAct...
+ </property>
There is no "org.freedesktop.DBus.Property.EmitsChangedSignal"
annotation and the default value is "true". We need to change the
default value so there needs to be
<annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal"
value="false"/>
at the same level as <property ...> elements.
For example you can check "data/org.libvirt.Domain.xml".
Otherwise looks good.
Pavel
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)