Building the 0.8.8 release candidate on cygwin produced this compiler warning, which is indicative of catastrophic failure on any attempt to print an error message with errno turned to a string: CC strerror_r.lo strerror_r.c: In function 'rpl_strerror_r': strerror_r.c:67: warning: assignment makes integer from pointer without a cast This has been fixed in gnulib. * .gnulib: Update to latest, for strerror_r fix. * src/util/memory.c (includes): Satisfy 'make syntax-check'. --- Pushing this under the build-breaker rule, even if cygwin is the only platform where the build was broken. * .gnulib 2f41af6...4cce65c (113):
doc: update users.txt doc: update users.txt doc: update users.txt gnulib-tool: Make copyright notice adjustment more robust. New module 'towctrans'. New module 'wctrans'. New module 'iswctype'. New module 'wctype'. wctype-h: Ensure wctype_t and wctrans_t are defined. flock: fix license typo Split large sed scripts, for HP-UX sed. stdlib: improve random_r modularization stdlib: don't depend on stdint getloadavg: don't depend on c-strtod, cloexec, fcntl-safer di-set.h, ino-map.h: add multiple-inclusion guard iswblank: Ensure declaration on glibc systems. New module 'iswblank'. di-set tests: Refactor. ino-map tests: Refactor. di-set: add "const" to a cast ChangeLog: fix my old entry to give credit to Bastien update from texinfo Rename module 'wctype' to 'wctype-h'. New module 'wcswidth'. New module 'wcstok'. New module 'wcsstr'. New module 'wcspbrk'. New module 'wcsspn'. New module 'wcscspn'. New module 'wcsrchr'. New module 'wcschr'. New module 'wcsdup'. New module 'wcsxfrm'. New module 'wcscoll'. New module 'wcsncasecmp'. New module 'wcscasecmp'. New module 'wcsncmp'. New module 'wcscmp'. New module 'wcsncat'. New module 'wcscat'. New module 'wcpncpy'. New module 'wcsncpy'. New module 'wcpcpy'. New module 'wcscpy'. New module 'wcsnlen'. New module 'wcslen'. New module 'wmemset'. New module 'wmemmove'. New module 'wmemcpy'. New module 'wmemcmp'. di-set, ino-map: new modules, from coreutils getloadavg: merge minor changes from Emacs Allow multiple gnulib generated replacements to coexist. libposix: Revert the unreviewed part of yesterday's big merge. unsetenv: work around Haiku issues libposix: Add _HEADERS primaries to posix modules. Modify gnulib-tool to strip them from generated Makefile.am-s where they are not needed. Also, replace M4 macro prefixes when requested. Finally, omit calls to error() for libposix. strerror_r-posix: port to cygwin New module 'wmemchr', part 3. New module 'wmemchr', part 2. New module 'wmemchr'. fdopendir: detect FreeBSD bug stdbool: do not define HAVE_STDBOOL_H wcsnrtombs: Prepare for new module wwcsnrtombs. wcsrtombs: Prepare for new module wwcsrtombs. mbsnrtowcs: Prepare for new module mbsnrtowwcs. mbsrtowcs: Prepare for new module mbsrtowwcs. vasnprintf: Reduce use of malloc for small format strings. autoudpate update from texinfo dup2: work around Haiku bug doc: off_t is not available in eglibc 2.11.2 stdio.h. ignore-value: add missing test dependency mktime: clarify long_int width checking ignore-value: Fix self-test. TYPE_MAXIMUM: avoid theoretically undefined behavior mktime: #undef mktime before #defining it mktime: systematically normalize tm_isdst comparisons mktime: fix some integer overflow issues and sidestep the rest mktime: avoid infinite loop rename, unlink, same-inode: Relicense. mktime: avoid problems on NetBSD 5 / i386 autoupdate mktime: fix misspelling in comment move-if-change: cope with concurrent mv of identical file. users.txt: Mention sharutils. doc: Update users.txt Prepare for supporting FreeBSD 10. Prepare for supporting FreeBSD 10. vma-iter, get-rusage-as: Add OpenBSD support. more make vars for makeinfo regen fcntl: work around Haiku F_DUPFD bugs autoupdate Enable memory leak tests on AIX. Tests for module 'get-rusage-data'. New module 'get-rusage-data'. get-rusage-as: Allow for easier testing. vma-iter: Treat Haiku like BeOS. c-stack: fix regression on cygwin when libsigsegv is present autoupdate vma-iter: Avoid empty intervals. u64: remove unnecessary #include Allow the user to avoid the GNULIB_TEST_* macros. New module 'vma-iter'. uninorm: Tweak includes. get-rusage-as: Improve on NetBSD. xreadlink.h: remove unnecessary #include maint.mk: add syntax-check rule: detect unnecessary #include <stddef.h> get-rusage-as: Fix bug. wctype: Ensure valid C syntax. wctype: Ensure valid C syntax. getopt: omit HAVE_OPTRESET, HAVE_GETOPT_CLIP from config.h gl_CHECK_NEXT_HEADERS implies AC_CHECK_HEADERS_ONCE
.gnulib | 2 +- src/util/memory.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.gnulib b/.gnulib index 2f41af6..4cce65c 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 2f41af65087fb2460779bc4e7fb62453f79ebae3 +Subproject commit 4cce65cb2f10936f13760625f39d532564984fde diff --git a/src/util/memory.c b/src/util/memory.c index 03e2e80..bfa32a8 100644 --- a/src/util/memory.c +++ b/src/util/memory.c @@ -1,7 +1,7 @@ /* * memory.c: safer memory allocation * - * Copyright (C) 2010 Red Hat, Inc. + * Copyright (C) 2010-2011 Red Hat, Inc. * Copyright (C) 2008 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -22,7 +22,6 @@ #include <config.h> #include <stdlib.h> -#include <stddef.h> #include "memory.h" #include "ignore-value.h" -- 1.7.4