On 09.12.2016 17:36, Maxim Nestratov wrote:
Implicit devices like controllers are confusing for CTs as they are faked. Other devices like video we require to be specified explicitly.
I would drop last sentence. prlsdkApplyVideoParams shows that we ignore video params for containers. Let's reword commit message as we discussed offline - virDomainDefAddImplicitDevices is just never intended for containers.
Signed-off-by: Maxim Nestratov <mnestratov@virtuozzo.com> --- src/vz/vz_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index a6236d0..1030a1b 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -1816,7 +1816,7 @@ prlsdkLoadDomain(vzDriverPtr driver, if (prlsdkGetDomainState(dom, sdkdom, &domainState) < 0) goto error;
- if (virDomainDefAddImplicitDevices(def) < 0) + if (!IS_CT(def) && virDomainDefAddImplicitDevices(def) < 0) goto error;
if (def->ngraphics > 0) {
ACK