Re: [libvirt] [PATCHv3 2/4] Add domainCoreDump to libxl driver

On Mon, May 30, 2011 at 10:57:46PM -0600, Jim Fehlig wrote: > Markus Groß wrote: > >> v2: >> * incorporated Jim Fehlig's review >> >> --- >> src/libxl/libxl_driver.c | 95 ++++++++++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 95 insertions(+), 0 deletions(-) >> >> > ACK, but I suspect we'll have to wait until 0.9.2 is released before pushing > > [...] > >> @@ -3265,6 +3359,7 @@ static virDriver libxlDriver = { >> .domainSetMemoryFlags = libxlDomainSetMemoryFlags, /* 0.9.0 */ >> .domainGetInfo = libxlDomainGetInfo, /* 0.9.0 */ >> .domainGetState = libxlDomainGetState, /* 0.9.2 */ >> + .domainCoreDump = libxlDomainCoreDump, /* 0.9.2 */ >> >> > And remember to change this to 0.9.3 before doing so. > Actually it's a pure addition, I fine to push if we push it today,