Re: [PATCH 1/1] domain_conf.c: skip checking ZPCI address is incomplete if not present

On 6/27/20 10:32 AM, Andrea Bolognani wrote: > In the future, please don't include CC tags in your commits: removing > them results in extra work when picking up a patch, and it's also > generally not considered very polite to CC individual developers. > Everyone is subscribed to the list anyway :) I screwed up with the CC: tags in the commit msg. I usually do it via "--cc" in git-sendpatch in these cases. As for not being polite, I CC'ed the people that was related with the commit that I was fixing (signed-off/reviewed-by). Perhaps I should have CC'ed just the author instead .... assuming that CC'ing the author of the commit I'm amending is OK here in Libvirt, of course. At least in the QEMU mailing list it's not just OK, but encouraged to CC the author of the commit you're fixing to make the person aware.