Re: [PATCH] lxc: Set default security model in XML parser config

On Mon, Dec 07, 2020 at 11:40:49AM +0100, Michal Privoznik wrote: > On 12/7/20 10:28 AM, Daniel P. Berrangé wrote: >> On Fri, Dec 04, 2020 at 05:12:14PM -0700, Jim Fehlig wrote: >>> On 12/4/20 2:35 AM, Daniel P. Berrangé wrote: >>>> On Thu, Dec 03, 2020 at 04:25:42PM -0700, Jim Fehlig wrote: >>>>> Attempting to create a lxc domain with <seclabel type='none'/> fails >>>>> >>>>> virsh --connect lxc:/// create distro_nosec.xml >>>>> error: Failed to create domain from distro_nosec.xml >>>>> error: unsupported configuration: Security driver model '(null)' is not available >>>> >>>> Is this a regression, or has it always been broken like this ? >>> >>> It's a regression. Works with libvirt 5.1.0 but not 6.0.0. Do you want me to >>> dig further and try to finger a commit? >> >> Yea, if you could find the commit causing it that'd be great, as I'm not >> entirely convinced by the change here. > > I thought I dig the commit here, didn't I? > > https://www.redhat.com/archives/libvir-list/2020-December/msg00245.html Ah, i missed that reply. This makes more sense now. Can you just reference that in the commit message before pushing this.