Re: [libvirt] [PATCH] cgroup: avoid leaking a file

On 05/03/2011 05:49 PM, Eric Blake wrote: >Clang detected a dead store to rc. It turns out that in fixing this, >I also found a FILE* leak. > >* src/util/cgroup.c (virCgroupKillInternal): Abort rather than >resuming loop on fscanf failure, and cleanup file on error. This definitely fixes the FILE* leak, but do we really want to abort the loop (stop looking for more pidfiles) when fscanf fails on one pidfile? (dunno, just asking)

>@@ -1376,7 +1377,8 @@ static int virCgroupKillInternal(virCgroupPtr group, int signum, virHashTablePtr > if (feof(fp)) > break; > rc = -errno; >- break; >+ VIR_DEBUG("Failed to read %s: %m\n", keypath); >+ goto cleanup; > } > if (virHashLookup(pids, (void*)pid)) > continue;