Re: [libvirt] [PATCH V5 07/12] src/xenxs: Refactor code formating xm disk config

Kiarie Kahurani wrote:

introduce function xenFormatXMDomainDisks(virConfPtr conf,.........); which formats domain disks config instead

Signed-off-by: Kiarie Kahurani <davidkiarie4@gmail.com> --- src/xenxs/xen_xm.c | 72 +++++++++++++++++++++++++++++++++--------------------- 1 file changed, 44 insertions(+), 28 deletions(-)

diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c index b4a7468..2c381f8 100644 --- a/src/xenxs/xen_xm.c +++ b/src/xenxs/xen_xm.c @@ -1907,6 +1907,49 @@ xenFormatXMCharDev(virConfPtr conf, virDomainDefPtr def) }

+static int +xenFormatXMDomainDisks(virConfPtr conf, virDomainDefPtr def, + int xendConfigVersion)

Style nit I mentioned in the other patch. Otherwise ACK. Regards, Jim