Re: [libvirt] [PATCH 4/4] Move virRun, virExec*, virFork to util/command

On 05/17/2011 09:06 AM, Cole Robinson wrote: > Seems reasonable to have all command wrappers in the same place > > v2: > Dont move SetInherit > > v3: > Comment spelling fix > Adjust WARN0 comment > Remove spurious #include movement > Don't include sys/types.h > Combine virExec enums > > Signed-off-by: Cole Robinson <crobinso(a)redhat.com&gt; > @@ -42,9 +48,13 @@ > virReportErrorHelper(VIR_FROM_NONE, code, __FILE__, \ > __FUNCTION__, __LINE__, __VA_ARGS__) Looks like you addressed all my comments; and sorry for the delay on this last round of reviews. ACK. Overall, this is a rather large change to be pushing after feature freeze; I'm 50-50 on whether we should delay this until after the release, since it is missing test exposure by not being part of RC1. Does anyone else have an opinion on whether this is safe enough to push now?