Re: [Libvir] PATCH: Fix crash if client acl check fails
On Wed, Jul 11, 2007 at 04:04:42PM -0400, Daniel Veillard wrote:
On Wed, Jul 11, 2007 at 08:46:00PM +0100, Daniel P. Berrange wrote:
> There was a couple of places where if the ACL check for an incoming client
> failed, it would go on and register the client's FD in the event loop
> anyway. The trouble is, after the ACL failed, the client had been forcably
> disconnected & the client struct free'd, so the daemon died in the event
> loop a short time later. This patch fixes it & makes a couple of other
> places more paranoid about checking too
All those looks like serious bugs +1
Committed now.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|