Re: [libvirt PATCH 41/42] systemd: Improve and unify unit descriptions
On Wed, Sep 27, 2023 at 10:57:13AM +0100, Daniel P. Berrangé wrote:
On Mon, Sep 25, 2023 at 08:58:39PM +0200, Andrea Bolognani wrote:
> +++ b/src/locking/virtlockd-admin.socket.in
> @@ -1,5 +1,5 @@
> [Unit]
> -Description=Virtual machine lock manager admin socket
> +Description=libvirt @name@ daemon admin socket
Using a subsitution here does not add any value IMHO, it
just obscures the final text. Likewise for the similar
changes that follow.
Point taken for libvirtd/virtlogd/virtlockd, which are special and
don't follow the same process as other daemons. I'll drop that part.
--
Andrea Bolognani / Red Hat / Virtualization