Re: [libvirt] [PATCH] Unify *ReportError logic

On Thu, Oct 02, 2008 at 03:41:21PM -0400, Cole Robinson wrote: > Currently, most src/* files have their own ReportError > function. Some support printf style arguments, others > only allow reporting a single string message. The code > for all of them does virtually the same thing, possibly > passing a different constant off to another function. > > The attached patch adds a function to virterror.c which > encapsulates the common ReportError logic. I used this > to replace qemudReportError with a macro, which also > allows passing off filename and line number info if > we wanted to do something with it later. > > I did just the one function conversion to see what > people think: if I'm missing something, or ideas for > anything else to add. Seems to work as expected in > my testing. Basically a good idea - we've discussed doing exactly this in the past. You can do further though, and kill off the 'dom' and 'net' parameters here too. Those are deprecated and should always be left NULL these days.

Likewise passing the filename/linenr is not much use - if a particular error message wants to include file/line number then they can be includes as args to the printf fmt string.