On 04/21/14 10:32, Jiri Denemark wrote:
This patch implements formating and parsing code for the backing
store
schema defined and documented by the previous patch.
This patch does not aim at providing full persistent storage of disk
backing chains yet. The formatter is supposed to provide the backing
chain detected when starting a domain and thus it is not formatted into
an inactive domain XML. The parser is implemented mainly for the purpose
of testing the XML generated by the formatter and thus it does not
distinguish between no backingStore element and an empty backingStore
element. This will have to change once we fully implement support for
user-supplied backing chains.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
src/conf/domain_conf.c | 128 +++++++++++++++++++++
...
54 files changed, 211 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 99b57ee..9dbe0af 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
...
@@ -5842,6 +5910,9 @@ virDomainDiskDefParseXML(virDomainXMLOptionPtr
xmlopt,
&& virDomainDiskDefAssignAddress(xmlopt, def) < 0)
goto error;
+ if (virDomainDiskBackingStoreParse(ctxt, &def->src) < 0)
+ goto error;
+
cleanup:
VIR_FREE(bus);
VIR_FREE(type);
Hmmm, I think we should notify the user somehow that the parsed input
will be ignored, but that can be done later as we still have time until
the release.
ACK.
Peter