On Tue, Dec 18, 2012 at 01:40:45PM -0700, Eric Blake wrote:
On 12/14/2012 08:08 AM, Viktor Mihajlovski wrote:
There was a double free issue caused by virSysinfoRead on s390, as the same manufacturer string instance was assigned to more than one processor record. Cleaned up other potential memory issues and restructured the sysinfo parsing code by moving repeating patterns into a helper function.
+# if BROKEN_GCC_WLOGICALOP +# pragma GCC diagnostic ignored "-Wlogical-op" +# endif
Do you have cppi installed? If so, I'm surprised this passed 'make syntax-check'. The middle line should be indented further as:
# if ... # pragma ... # endif
to keep cppi happy.
Indeed, I fixed this when I pushed the patch Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|