Re: [libvirt] Updated James Morris patch to apply to libvirt-0.6.0 version
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jim Meyering wrote:
Daniel P. Berrange wrote:
> Just spotted one serious problem we need to address. The
> method 'qemudStartVMDaemon' quoted here is where we set the
> security label:
...
Good catch.
> To use this, we'd make qemudStartVM() pass in a virExecHook callback
> which does the call to qemudDomainSetSecurityLabel()
>
> Daniel
>
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -291,6 +291,7 @@ virEnumToString;
> virEventAddHandle;
> virEventRemoveHandle;
> virExec;
> +virExecWithHook;
Looks right to me.
ACK.
This patch looks good to me and I have already rebased the svirt patch
to match, waiting for this to get applied, then I will resubmit my patch.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iEYEARECAAYFAkmiqhYACgkQrlYvE4MpobMkFACeMWEmQfwKMe4Cn7NNikPk9f3+
zlMAoK7DeqbpTKho4Kw/bZtuA86vtMJK
=eVSb
-----END PGP SIGNATURE-----