Re: [libvirt] [PATCHv2 0/2] Restore logical pool functionality
On 03/28/2017 04:40 AM, Ján Tomko wrote:
John Ferlan (1):
storage: Better describe logical pool creation/definition parameters
Ján Tomko (1):
Revert "storage: Better describe logical pool creation/definition
parameters"
src/conf/storage_conf.c | 8 --------
tools/virsh.pod | 7 +++----
2 files changed, 3 insertions(+), 12 deletions(-)
ACK series,
John
Since it was asked... The answer to "why" comes from reading the bz and
considering the frustration of someone that was trying to use the virsh
pool-define-as command to create a logical pool and well assuming more
about the name given the test pools I have. In the long run source.name
is the key for the pool and volume group connection. There there was
code that copied source.name from name when source.name was not
provided, so something just clicked that said well the opposite must be
true to if someone provides both then they should be the same.