On Fri, Feb 14, 2020 at 02:04:48PM +0100, Ján Tomko wrote:
On Fri, Feb 14, 2020 at 12:52:06PM +0000, Daniel P. Berrangé wrote:
Tests which are using the QEMU monitor / agent need to have an event thread running a private GMainContext.
There is already a thread running the main libvirt event loop but this can't be eliminated yet as it is used for more than just the monitor client I/O.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/qemumonitortestutils.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index b29e5d8cd2..a1641050ea 100644 --- a/tests/qemumonitortestutils.c +++ b/tests/qemumonitortestutils.c @@ -1389,12 +1398,16 @@ qemuMonitorTestNewAgent(virDomainXMLOptionPtr xmlopt) { qemuMonitorTestPtr test = NULL; virDomainChrSourceDef src; + g_autofree char *threadName = NULL;
../../tests/qemumonitortestutils.c:1402:22: error: unused variable 'threadName' [-Werror,-Wunused-variable] g_autofree char *threadName = NULL; ^
ANother left over Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|