On 03/09/2010 08:47 AM, Jim Meyering wrote:
Eric Blake wrote: ...
+ +static int parse_socket(int cpu) +{
Several tools (such as ctag, or even more simply, 'git grep "^func"') work better if all function implementations are listed with split lines, such that the function name starts at the first column:
static int parse_socket(int cpu) {
Would it be worth a global cleanup patch that does this throughout libvirt, rather than the current ad hoc mix in declaration styles?
IMHO, definitely worthwhile.
Here's the stats of running $ for f in $(git ls-files '*.[ch]') ; do cppi $f > $f.t && mv $f.t $f; done 172 files changed, 2895 insertions(+), 2895 deletions(-) I'm now browsing through the results to make sure they look sane, before posting the patch. Then it would be a matter of adding a cfg.mk check that runs 'cppi -a -c' on the same set of files during 'make syntax-check', as well as an addition to bootstrap.conf to require cppi. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org