Re: [libvirt] [PATCH 3/6] storage: fs: Compile file backends even if filesystem support is disabled
On 01/18/2017 06:36 AM, Peter Krempa wrote:
The file backend code was mistakenly put into #if WITH_STORAGE_FS.
This
is not necessary since all the backends just access files on disk, and
thus the code for WITH_STORAGE_DIR is sufficient to compile everything.
---
src/storage/storage_backend_fs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
OK so with a better picture - I understand now. The WITH*_FS is needed
in storage_backend.c....
ACK
John
diff --git a/src/storage/storage_backend_fs.c
b/src/storage/storage_backend_fs.c
index 7d18ad7c9..ba8aa20a2 100644
--- a/src/storage/storage_backend_fs.c
+++ b/src/storage/storage_backend_fs.c
@@ -1389,6 +1389,7 @@ virStorageBackend virStorageBackendNetFileSystem = {
.downloadVol = virStorageBackendVolDownloadLocal,
.wipeVol = virStorageBackendVolWipeLocal,
};
+#endif /* WITH_STORAGE_FS */
typedef struct _virStorageFileBackendFsPriv virStorageFileBackendFsPriv;
@@ -1573,5 +1574,3 @@ virStorageFileBackend virStorageFileBackendDir = {
.storageFileGetUniqueIdentifier = virStorageFileBackendFileGetUniqueIdentifier,
};
-
-#endif /* WITH_STORAGE_FS */