Re: [libvirt PATCH 3/5] tests: add AMD SEV bits into qemu-6.1.0 replies
On Fri, Jun 11, 2021 at 15:24:11 +0200, Pavel Hrdina wrote:
Currently we only have AMD SEV bits in qemu-2.12.0 replies which is
way
too old to test new features that require AMD SEV as well.
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 5 ++++-
tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 5 ++++-
tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 5 ++++-
tests/qemucapabilitiesdata/caps_6.1.0.x86_64.replies | 12 +++++++-----
tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 7 +++++++
5 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml
b/tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml
index 057824d795..9fcba182fa 100644
--- a/tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml
@@ -210,6 +210,9 @@
<genid supported='yes'/>
<backingStoreInput supported='yes'/>
<backup supported='no'/>
- <sev supported='no'/>
+ <sev supported='yes'>
+ <cbitpos>47</cbitpos>
+ <reducedPhysBits>1</reducedPhysBits>
+ </sev>
NACK, this will get overwritten next time I'll regenerate these.
Ideally we don't turn these into synthetic at least until the 6.1 cycle
is over.
If we want to keep having synthetic caps, I suggest we add another
qualifier to the name so that we can have two instances for a machine
and version tuple so we can have distinct versions e.g. based on
different hardware.