Re: [libvirt] [ 1/3] autocreate tap device for ethernet network type
On 23.03.2016 13:08, Daniel P. Berrange wrote:
On Wed, Mar 23, 2016 at 02:39:34PM +0300, Vasiliy Tolstov wrote:
> 2016-03-23 14:34 GMT+03:00 Daniel P. Berrange <berrange(a)redhat.com>:
>> RAther than have you re-post again, I'll commit just this patch
>> with this IP & route stuff removed now.
>
>
> Ok, no problem with this. If you apply only part, that creates tap
> devices, this is good start for me.
Ok it is merged - just resubmit your code to add IP & route stuff as a
separate patch now.
Thing is, this breaks the build. 'make check' is failing now as it
really tries to create a tap device - we have used 'ethernet' type of
interface in our tests to avoid creating any device on the host. Mocking
all of the virNetDev* is going to be verbose. But I'm already working on it.
Michal