On Fri, 2020-07-24 at 17:28 +0100, Daniel P. Berrangé wrote:
On Fri, Jul 24, 2020 at 06:22:37PM +0200, Andrea Bolognani wrote:
I still think that the presence of an explicit 'netcat' parameter in the URI should result in switching to proxy=netcat instead of the default behavior, because the user is very clearly indicating that they want a specific netcat binary to be used as remote proxy.
You chopped out the context where that is done
+ if (proxy == VIR_NET_CLIENT_PROXY_AUTO && + netcatPath != NULL) { + proxy = VIR_NET_CLIENT_PROXY_NETCAT; + }
Oops, my bad O:-) Can you please add a short comment explaining why that code is there in the first place? Overall the UI looks quite sane now, thanks for tweaking it :) -- Andrea Bolognani / Red Hat / Virtualization