Re: [libvirt] [PATCH 01/13] Introduce the function virCgroupForHypervisor

On 06/05/2012 02:13 AM, tangchen wrote: > Introduce the function virCgroupForHypervisor() to create sub directory > for hypervisor thread(include I/O thread, vhost-net thread) According to your cover letter, this patch was written by Wen, but I don't see a From: listing or Signed-off-by or any other indication that would let 'git am' credit Wen as the author. Instead, it tries to credit you, using only your email alias 'tangchen' instead of your full name (again, by the cover letter, and looking at the current contents of AUTHORS, I assume you prefer 'Tang Chen'). > --- > src/libvirt_private.syms | 1 + > src/util/cgroup.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > src/util/cgroup.h | 4 ++++ > 3 files changed, 47 insertions(+), 0 deletions(-) > > /** > + * virCgroupForHypervisor: > + * > + * @driver: group for the domain > + * @group: Pointer to returned virCgroupPtr > + * > + * Returns 0 on success or -errno value on failure. Other than that, the patch looks fine to me, but can you please rebase it to latest libvirt.git and resubmit it so that it gets recorded with correct authorship?