Re: [libvirt] Re: [PATCH] Fix raw storage volume creation for allocation < capacity.

Cole Robinson wrote: > CreateXMLFrom changes accidentally caused all raw volume creation to be > fully allocated (as though allocation == capacity). Fix this. > > Also force CreateXMLFrom to maintain the previous behavior: sparseness > should still be maintained since we search for holes when copying, and the > clone behavior hasn't been tested with anything but the broken behavior.

> + /* Make sure allocation is at least as large as the destination cap, > + * to make absolutely sure we copy all possible contents */ > + if (newvol->allocation < origvol->capacity; > + newvol->allocation = origvol->capacity; > + Of course the tweak I make at the last second is completely invalid syntax :(. Besides needing the obvious fix above, the patch does work as expected.