Re: [libvirt] [PATCH V2 1/4] domain: Add new VCPU state "halted"
On 09/20/2016 04:10 AM, Viktor Mihajlovski wrote:
QEMU virtual CPUs can assume a halted state, which - depending on
the architecture - can indicate whether a CPU is in use by the
guest operating system.
A new VCPU state halted is introduced in preparation of the
support in the QEMU driver (and optionally others where deemed
appropriate).
Signed-off-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com>
Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com>
---
include/libvirt/libvirt-domain.h | 1 +
tools/virsh-domain.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
FWIW: Could be last patch, but that's just an ordering thing.
Considering points raised in review of other patches in this series,
extra credit to modify virsh.pod for 'vcpuinfo' (and 'domstats') to
describe the states ;-) (especially if they differ per architecture!).
Maybe there just needs to be "common" place to describe the VCPU states
much like there is a section describing the Domain States
diff --git a/include/libvirt/libvirt-domain.h
b/include/libvirt/libvirt-domain.h
index f1c35d9..0da2003 100644
--- a/include/libvirt/libvirt-domain.h
+++ b/include/libvirt/libvirt-domain.h
@@ -1682,6 +1682,7 @@ typedef enum {
VIR_VCPU_OFFLINE = 0, /* the virtual CPU is offline */
VIR_VCPU_RUNNING = 1, /* the virtual CPU is running */
VIR_VCPU_BLOCKED = 2, /* the virtual CPU is blocked on resource */
+ VIR_VCPU_HALTED = 3, /* the virtual CPU is halted */
# ifdef VIR_ENUM_SENTINELS
VIR_VCPU_LAST
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 3829b17..a6b239b 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -181,7 +181,8 @@ VIR_ENUM_IMPL(virshDomainVcpuState,
VIR_VCPU_LAST,
N_("offline"),
N_("running"),
- N_("blocked"))
+ N_("blocked"),
+ N_("halted"))
I've got some concerns over using "halted" here considering on my
findings...
static const char *
virshDomainVcpuStateToString(int state)