Re: [libvirt] [PATCH 1/2] Introduce new VIR_ERR_AGENT_UNRESPONSIVE error code
On 08/27/2012 01:57 PM, Michal Privoznik wrote:
Currently, when guest agent is configure but not responsive
s/configure/configured/
(e.g. due to appropriate service not running in the guest)
we return VIR_ERR_INTERNAL_ERROR or VIR_ERR_ARGUMENT_UNSUPPORTED.
There is no VIR_ERR_ARGUMENT_UNSUPPORTED in the patch.
Both are wrong. Therefore we need to introduce new error code
to reflect this case.
---
ACK with the commit message fixed,
Martin
P.S.: Looks like a nice start of the 'INTERNAL_ERROR' usage abusement ;)