Re: [libvirt] [PATCH 0/9] Deprecate more unused QEMU_CAPS
On Fri, May 20, 2016 at 10:52:20AM -0400, John Ferlan wrote:
On 05/20/2016 08:44 AM, Ján Tomko wrote:
> Cleaning up after QEMU_CAPS_DEVICE I noticed QEMU_CAPS_DRIVE_READONLY
> depends on it and QEMU_CAPS_PCIDEVICE did not really matter.
>
> Ján Tomko (9):
> qemu_command: assume QEMU_CAPS_DEVICE
> qemu: assume QEMU_CAPS_DEVICE almost everywhere
> tests: remove disk-drive-fat test
> tests: remove <readonly/> from IDE disks
> tests: always assume QEMU_CAPS_DRIVE_READONLY
> qemu: always assume QEMU_CAPS_DRIVE_READONLY
> Deprecate QEMU_CAPS_DRIVE_READONLY
> Deprecate QEMU_CAPS_DEVICE
> Deprecate QEMU_CAPS_PCIDEVICE
>
> 85 files changed, 246 insertions(+), 631 deletions(-)
> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fat.args
> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fat.xml
>
Other than the unexpected removal of FSDEV_READONLY in patch 6, looks
good - ACK series modulo addressing that
Thanks, I have removed the FSDEV_READONLY change and pushed the series.
Jan