Re: [libvirt] [PATCH] virtlogd: Don't stop or restart along with libvirtd
On Tue, 2016-09-20 at 14:35 +0100, Daniel P. Berrange wrote:
ACK
Pushed, thanks.
FYI, systemd docs say
PartOf=
Configures dependencies similar to Requires=, but limited to
stopping and restarting of units. When systemd stops or restarts
the units listed here, the action is propagated to this unit. Note
that this is a one-way dependency — changes to this unit do not
affect the listed units.
we clearly don't want 'restart' propagated to virtlogd
or virtlockd - those units must only ever 'reexec'
themselves.
I was aware of that; however, I failed to understand that
virtlogd must never be restarted this way.
Thankfully downstream QE caught the faulty commit before
it could make it into a release :)
--
Andrea Bolognani / Red Hat / Virtualization