Re: [libvirt] [PATCH 05/14] conf: Introduce VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE

On Thu, 2017-11-16 at 12:30 +0100, Pavel Hrdina wrote: > > @@ -9143,6 +9143,14 @@ qemuChrIsPlatformDevice(const virDomainDef *def, > > return true; > > } > > > > + /* If we got all the way here and we're still stuck with the default > > + * target type for a serial device, it means we have no clue what kind of > > + * device we're talking about and we must treat it as a platform device */ > > Missing full stop/period at the end of the sentence. Is that a thing now? It seems like *not* having the full stop is way more common: $ git grep -E '\.($| \*/)' src/ | grep -iEv 'copyr|licen' | wc -l 8166 $ git grep -E '[^\.] \*/' src/ | wc -l 19772 with the former number being bigger than reality because of API documentation and such.