Re: [libvirt] [PATCH 3/3] lib: Check conditions for VIR_DOMAIN_BLOCK_REBASE_RELATIVE right away

> + if (flags & VIR_DOMAIN_BLOCK_REBASE_RELATIVE && !base) { > + virReportInvalidArg(base, "%s", > + _("flag VIR_DOMAIN_BLOCK_REBASE_RELATIVE is valid " > + "only with non-null base")); > + goto error; > + } I'd shorten this to: if (flags & VIR_DOMAIN_BLOCK_REBASE_RELATIVE) virCheckNonNullArgGoto(params, error);

for consistency with other validity checks in this file. I'd also like to see this restriction mentioned in the libvirt.c docs.