Re: [libvirt] [PATCH 3/3] lib: Check conditions for VIR_DOMAIN_BLOCK_REBASE_RELATIVE right away

8 Jul 2014


      On 07/08/2014 09:53 AM, Eric Blake wrote:
...
...
+    if (flags & VIR_DOMAIN_BLOCK_REBASE_RELATIVE && !base) {
+        virReportInvalidArg(base, "%s",
+                            _("flag VIR_DOMAIN_BLOCK_REBASE_RELATIVE is valid "
+                              "only with non-null base"));
+        goto error;
+    }
I'd shorten this to:
if (flags & VIR_DOMAIN_BLOCK_REBASE_RELATIVE)
    virCheckNonNullArgGoto(params, error);
too much copy-and-paste; I meant:
    virCheckNonNullArgGoto(base, error);
...
for consistency with other validity checks in this file.
I'd also like to see this restriction mentioned in the libvirt.c docs.
-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org