Re: [libvirt] [PATCH v2 6/7] qemu: Forbid MSR features with old QEMU

On Thu, Jun 20, 2019 at 12:53:41AM +0200, Jiri Denemark wrote:

Without "unavailable-features" CPU property we cannot properly detect whether a specific MSR feature we asked for (either explicitly or implicitly via a CPU model) was disabled by QEMU for some reason. Because this could break migration, snapshots, and save/restore operaions, it's better to just forbid any use of MSR features with QEMU which lacks "unavailable-features" CPU property.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- src/qemu/qemu_process.c | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano