19 Jan
2009
19 Jan
'09
3:14 p.m.
"Daniel P. Berrange" <berrange@redhat.com> wrote:
The 'inotify' driver currently keeps all its state in a global static variables. Not so great since we access this from all sorts of places and its hard to guarentee thread safety. Also, we're using per-connection FD watches to update this state, so if multiple Xen connections were active, they'd all be updating the same globl state. So we move the state into the virConnect object. This will increase memory usage if a single process has multiple Xen connections open though, but not by very much
Looks fine. ACK